Skip to content

uucore, process.rs: reduce usage of nix#12342

Open
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:getXid-rustix
Open

uucore, process.rs: reduce usage of nix#12342
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:getXid-rustix

Conversation

@oech3
Copy link
Copy Markdown
Contributor

@oech3 oech3 commented May 17, 2026

I'll split PR for getsid

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 17, 2026

GNU testsuite comparison:

Note: The gnu test tests/cp/link-heap is now being skipped but was previously passing.
Congrats! The gnu test tests/printf/printf-surprise is now passing!
Congrats! The gnu test tests/seq/seq-epipe is now passing!
Note: The gnu test tests/env/env-signal-handler was skipped on 'main' but is now failing.

xtqqczze
xtqqczze reviewed May 17, 2026
View reviewed changes
Comment thread src/uucore/src/lib/features/process.rs
@oech3 oech3 marked this pull request as ready for review May 17, 2026 01:36
@xtqqczze
Copy link
Copy Markdown
Contributor

xtqqczze commented May 17, 2026

To be honest, I'd rather just remove all of these from uucore.

@xtqqczze xtqqczze mentioned this pull request May 17, 2026
Open
@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented May 17, 2026

Yes. They are not useful.

@xtqqczze
Copy link
Copy Markdown
Contributor

xtqqczze commented May 17, 2026

OK, can you close in favor of #11158?

@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented May 17, 2026

I guess it needs more time to be merged. I'll close this after actuall references are removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@xtqqczze xtqqczze xtqqczze left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oech3 @xtqqczze